Appearance: use settings.create_action#445
Merged
Merged
Conversation
Member
|
We need to remove the old color scheme from accounts service then and update granite and elementary/greeter#786 to use it |
Member
|
Or we can remove this from granite entirely since granite already relies on portals |
Member
Author
|
@lenemter settings daemon already handles setting accountsservice when the key is changed, so I don't think there's any more changes needed here for that. It should still work the same |
Member
|
@danirabbit I found out about this too late lol. I've already proposed to remove color-scheme from accounts service |
lenemter
approved these changes
May 14, 2025
Member
lenemter
left a comment
lenemter
left a comment
There was a problem hiding this comment.
Code looks good and works as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #429
Rebase merge/review commits separately
Removes a bunch of complicated touching of accounts service and simplifies settings binding. When manually changing color scheme while schedule is enabled, schedule will be snoozed instead of changed to disabled. Settings Daemon now handles setting mutter settings, syncing accountsservice etc